The 'Old Edinburgh'
book published by Stenlake confirms the location (1930's aerial photos,
very good.) One shot shows the area around the Broughton Gas
Works. The buildings in the photograph above are very clearly shown, from
a different angle.
So the railway sidings are
at the end of Dryden Street, and the buildings behind the wagons and
lorries will be Brown Brothers (or Rosebank Foundry; I don't know
when Brown Bros moved there).
The photographer is
standing at the end of Dryden Terrace, on the bridge over the railway
line. The Shrubhill tram depot would have been immediately behind him.